Skip to content

FOUR-34491: UPdate index.blade to fix issue in empty components - #9190

Open
henryjonathanquispe wants to merge 1 commit into
developfrom
FOUR-34491
Open

henryjonathanquispe wants to merge 1 commit into
developfrom
FOUR-34491

Conversation

@henryjonathanquispe

Copy link
Copy Markdown
Contributor

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@cursor

cursor Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Build and script-order change for request show pages only; no auth or data-handling changes.

Overview
Fixes request detail pages where Vue components appeared empty by changing how show.js is loaded.

Previously loaderRequestsShow.js dynamically imported ./show after setup. show.js is now a separate Vite entry listed in vite.config.js and included via @vite on show.blade.php and showMobile.blade.php, alongside the existing loader scripts. The loader no longer performs that import and only wires Screen Builder and package globals.

This keeps component registration (RequestDetail, DataSummary, mobile variants, etc.) on a predictable script load path instead of an async chunk that could race with inline Vue bootstrapping.

Reviewed by Cursor Bugbot for commit 1d4e8a1. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1d4e8a1. Configure here.

@section('js')
@vite(['resources/js/requests/loaderRequestsShow.js'])
@vite(['resources/js/processes/modeler/initialLoad.js'])
@vite(['resources/js/requests/show.js'])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate show.js Vite include

Low Severity

Mobile request detail now emits @vite for resources/js/requests/show.js twice. The new tag was added above the package-files script, but the same entry was already included later in the same js section. The extra include is redundant and makes script order harder to follow.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1d4e8a1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant